netdev - Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369605607.2034.4.camel@joe-AO722>
Date:	Sun, 26 May 2013 15:00:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	atomlin@...hat.com, netdev@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, pshelar@...ira.com, mst@...hat.com,
	alexander.h.duyck@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for
 dropped packets

On Sun, 2013-05-26 at 20:28 +0400, Sergei Shtylyov wrote:
> On 26-05-2013 17:17, atomlin@...hat.com wrote:
> > Failed GFP_ATOMIC allocations by the network stack result in dropped
> > packets, which will be received on a subsequent retransmit, and an
> > unnecessary, noisy warning with a kernel backtrace.
> 
> > These warnings are harmless, but they still cause users to panic and
> > file bug reports over dropped packets. It would be better to hide the
> > failed allocation warnings and backtraces, and let retransmits handle
> > dropped packets quietly.

> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
[]
> > @@ -236,7 +236,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
> >   		? skbuff_fclone_cache : skbuff_head_cache;
> >
> >   	if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX))
> > -		gfp_mask |= __GFP_MEMALLOC;
> > +		gfp_mask |= (__GFP_MEMALLOC|__GFP_NOWARN);
> 
>     Parens not needed here.

Maybe add a pr_debug before the goto out instead.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html