netdev - Re: [PATCH] ptp_pch: depends on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130525.231129.392417150870789444.davem@davemloft.net>
Date:	Sat, 25 May 2013 23:11:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kyle@...hat.com
Cc:	netdev@...r.kernel.org, richardcochran@...il.com
Subject: Re: [PATCH] ptp_pch: depends on PCI

From: Kyle McMartin <kyle@...hat.com>
Date: Sat, 25 May 2013 12:55:07 -0400

> It's only accessible via PCI, but has no dependencies, so it ends up
> being selected on s390 where a bunch of primitives only exist if
> CONFIG_PCI=y (such as {request,free}_irq)
> 
> Signed-off-by: Kyle McMartin <kyle@...hat.com>

I've already told the s390 people they have to fix this properly.

They have to provide stubs for request_irq() et al. when CONFIG_PCI
is not enabled.

This Kconfig change is therefore not appropriate.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html