netdev - Re: [PATCH 1/3 net-next v3] net: ethtool: disambiguate XCVR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369673396.3469.389.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 27 May 2013 17:49:56 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Florian Fainelli <f.fainelli@...il.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<afleming@...escale.com>, <jogo@...nwrt.org>
Subject: Re: [PATCH 1/3 net-next v3] net: ethtool: disambiguate XCVR_*
 meaning

On Thu, 2013-05-23 at 12:11 +0100, Florian Fainelli wrote:
> Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and
> Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and
> Ethernet MAC in a different package/die). Most if not all of the drivers
> setting their transceiver type already do it the way the comment
> describes it.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

I had another look over the drivers that use both values, and I think
there aren't any remaining exceptions to the definition you're giving.
Sorry for holding this up.

Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Ben.

> ---
>  include/uapi/linux/ethtool.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 0c9b448..38dbafa 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits {
>  #define PORT_OTHER		0xff
>  
>  /* Which transceiver to use. */
> -#define XCVR_INTERNAL		0x00
> -#define XCVR_EXTERNAL		0x01
> +#define XCVR_INTERNAL		0x00 /* PHY and MAC are in the same package */
> +#define XCVR_EXTERNAL		0x01 /* PHY and MAC are in different packages */
>  #define XCVR_DUMMY1		0x02
>  #define XCVR_DUMMY2		0x03
>  #define XCVR_DUMMY3		0x04

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html