| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <51A39A3F.8080903@redhat.com> Date: Mon, 27 May 2013 13:39:11 -0400 From: Rik van Riel <riel@...hat.com> To: atomlin@...hat.com CC: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, pshelar@...ira.com, mst@...hat.com, alexander.h.duyck@...el.com, aquini@...hat.com, sergei.shtylyov@...entembedded.com, linux-kernel@...r.kernel.org Subject: Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets On 05/26/2013 04:19 PM, atomlin@...hat.com wrote: > From: Aaron Tomlin <atomlin@...hat.com> > > Since v1: > - Removed unnecessary parentheses > > ---8<--- > > Failed GFP_ATOMIC allocations by the network stack result in dropped > packets, which will be received on a subsequent retransmit, and an > unnecessary, noisy warning with a kernel backtrace. > > These warnings are harmless, but they still cause users to panic and > file bug reports over dropped packets. It would be better to hide the > failed allocation warnings and backtraces, and let retransmits handle > dropped packets quietly. Yes please. Getting memory management bug reports for dropped network packets got old years ago. Lets get rid of those messages. > Signed-off-by: Aaron Tomlin <atomlin@...hat.com> Reviewed-by: Rik van Riel <riel@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists