netdev - Re: [PATCH] net/usb/kalmia: use %*phC to dump small buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vfv7q7ACuS0_x0V1rwHTbvMcmYfgcJmFmrJpasFMMGXEQ@mail.gmail.com>
Date:	Tue, 28 May 2013 21:21:10 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	USB <linux-usb@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/usb/kalmia: use %*phC to dump small buffers

On Tue, May 28, 2013 at 9:14 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 28-05-2013 13:56, Andy Shevchenko wrote:

>> @@ -263,32 +260,24 @@ kalmia_rx_fixup(struct usbnet *dev, struct sk_buff
>> *skb)
>>                                 sizeof(EXPECTED_UNKNOWN_HEADER_1)) ||
>> !memcmp(
>>                                 header_start, EXPECTED_UNKNOWN_HEADER_2,
>>                                 sizeof(EXPECTED_UNKNOWN_HEADER_2))) {
>> -                               netdev_dbg(
>> -                                       dev->net,
>> -                                       "Received expected unknown frame
>> header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n",
>> -                                       header_start[0], header_start[1],
>> -                                       header_start[2], header_start[3],
>> -                                       header_start[4], header_start[5],
>> +                               netdev_dbg(dev->net,
>> +                                       "Received expected unknown frame "
>> +                                       "header: %6phC. Package length:
>> %i\n",
>
>    Message strings shouldn't be broken, despite 80 chars limit (there's an
> exception for them in checkpatch.pl).

I'm glad to hear that checkpatch.pl is eventually fixed.
Will send patch v2 tomorrow.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html