netdev - Re: [PATCH net v2] ipv4: fix redirect handling for TCP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130527.234008.2288985801653974436.davem@davemloft.net>
Date:	Mon, 27 May 2013 23:40:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mkubecek@...e.cz
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net
Subject: Re: [PATCH net v2] ipv4: fix redirect handling for TCP packets

From: Michal Kubecek <mkubecek@...e.cz>
Date: Tue, 28 May 2013 08:26:49 +0200

> Unlike ipv4_redirect() and ipv4_sk_redirect(), ip_do_redirect()
> doesn't call __build_flow_key() directly but via
> ip_rt_build_flow_key() wrapper. This leads to __build_flow_key()
> getting pointer to IPv4 header of the ICMP redirect packet
> rather than pointer to the embedded IPv4 header of the packet
> initiating the redirect.
> 
> As a result, handling of ICMP redirects initiated by TCP packets
> is broken. Issue was introduced by
> 
> 	4895c771c ("ipv4: Add FIB nexthop exceptions.")
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html