netdev - Re: [patch net-next v2 1/3] net: pass info struct via netdevice notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130528092539.GA1619@minipsycho.brq.redhat.com>
Date:	Tue, 28 May 2013 11:25:39 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [patch net-next v2 1/3] net: pass info struct via netdevice
 notifier

Tue, May 28, 2013 at 10:54:28AM CEST, xiyou.wangcong@...il.com wrote:
>On Tue, 28 May 2013 at 08:24 GMT, Jiri Pirko <jiri@...nulli.us> wrote:
>>  simeth_device_event(struct notifier_block *this,unsigned long event, void *ptr)
>>  {
>> -	struct net_device *dev = ptr;
>> +	struct net_device *dev = get_netdevice_nofifier_info_dev(ptr);
>
>typo above....

ia64, that's why this passed through my build test :/ Will fix this

>
>BTW, get_netdevice_notifier_info_dev() really sucks, can we make it
>shorter? For example, notifier_into_to_dev()?

I wanted to mention namespace there.
Maybe "netdev_notifier_info_to_dev"

Thanks

>
>Thanks.
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html