netdev - Re: [PATCH 09/11] net: emaclite: Do not use microblaze and ppc IO functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51A6271A.5090809@monstr.eu>
Date:	Wed, 29 May 2013 18:04:42 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Michal Simek <michal.simek@...inx.com>
CC:	linux-kernel@...r.kernel.org, Bill Pemberton <wfp5p@...ginia.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 09/11] net: emaclite: Do not use microblaze and ppc IO
 functions

On 05/29/2013 05:33 PM, Michal Simek wrote:
> Emaclite can be used on ARM zynq where in_be32/out_be32 IO
> functions are not present. Use standard __raw_readl/__raw_writel
> IO functions instead.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 100 +++++++++++++-------------
>  1 file changed, 51 insertions(+), 49 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 93bb14e..0d8515b 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -159,34 +159,34 @@ static void xemaclite_enable_interrupts(struct net_local *drvdata)
>  	u32 reg_data;
> 
>  	/* Enable the Tx interrupts for the first Buffer */
> -	reg_data = in_be32(drvdata->base_addr + XEL_TSR_OFFSET);
> -	out_be32(drvdata->base_addr + XEL_TSR_OFFSET,
> +	reg_data = __raw_readl(drvdata->base_addr + XEL_TSR_OFFSET);
> +	__raw_writel(drvdata->base_addr + XEL_TSR_OFFSET,
>  		 reg_data | XEL_TSR_XMIT_IE_MASK);

oou - this is completely wrong.
Will do v2.

Sorry for that.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)