netdev - Re: [Patch net-next v3] net: clean up skb headers code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130530.131603.1155012584617016387.davem@davemloft.net>
Date:	Thu, 30 May 2013 13:16:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	amwang@...hat.com, netdev@...r.kernel.org,
	bhutchings@...arflare.com, horms@...ge.net.au
Subject: Re: [Patch net-next v3] net: clean up skb headers code 

From: "David Laight" <David.Laight@...LAB.COM>
Date: Thu, 30 May 2013 12:18:13 +0100

>> commit 1a37e412a0225fcba5587 (net: Use 16bits for *_headers
>> fields of struct skbuff) converts skb->*_header to u16,
>> some #if NET_SKBUFF_DATA_USES_OFFSET are now useless,
>> and to be safe, we could just use "X = ~(typeof(X))0;"
>> as suggested by David and Ben.
> 
> IIRC ~(unsigned short)0 is the same as ~0 and will be -1.
> define an actual constant with value 0xffff

The problem with doing that is that if this type is changed again,
we'lll go through this same circus changing the constant everywhere
and missing some cases.

I absolutely want to see a version of this fix that makes sure that if
the type changes, either the constantly automatically change (that's
the "typeof(X)" approach) or the build breaks spectacularly until the
value is fixed up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html