netdev - Re: [PATCH net-next v3 2/2] vxlan: allow specifying multiple default destinations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF1J0HP+Wu9HjEELDaXM2BMREMuKByWr_zz=PwHeNUt=EVbdvw@mail.gmail.com>
Date:	Thu, 30 May 2013 14:16:26 +0300
From:	Mike Rapoport <mike.rapoport@...ellosystems.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] vxlan: allow specifying multiple default destinations

On Thu, May 30, 2013 at 12:09:48PM +0100, Thomas Graf wrote:
> Looks much better, thanks for taking the feedback. Some additional
> feedback inlined:
>
> > +   const struct vxlan_dev *vxlan)
> > +{
> > + struct vxlan_rdst *rdst;
> > + struct nlattr *nest, *rdst_nest;
> > + __be32 ip;
> > + int i;
> > +
> > + if (vxlan->remote_cnt) {
> > + nest = nla_nest_start(skb, IFLA_VXLAN_REMOTES);
> > + if (nest == NULL)
> > + goto nla_put_failure;
> > +
> > + for (rdst = vxlan->default_dst.remote_next, i = 0; rdst;
> > +     rdst = rdst->remote_next, i++) {
> > + ip = rdst->remote_ip;
> > +
> > + rdst_nest = nla_nest_start(skb, i);
>
> Attribute type '0' is reserved, please don't use it. Start with '1'.
>
> > +enum {
> > + IFLA_VXLAN_REMOTE_NEW,
> > + IFLA_VXLAN_REMOTE_DEL,
> > +};
>
> Same here, attribute type '0' is reserved.

Does it mean I have to add _UNSPEC and _MAX? And, consequently, rename
either REMOTE_{NEW,DEL} or REMOTE_ADDR and friends to avoid redefinition
of _MAX attribute?

--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html