netdev - RE: [Patch net-next] net: clean up skb headers code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B725B@saturn3.aculab.com>
Date:	Thu, 30 May 2013 13:22:14 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"David Laight" <David.Laight@...LAB.COM>,
	"Antonio Quartulli" <ordex@...istici.org>
Cc:	"Ben Hutchings" <bhutchings@...arflare.com>,
	"David Miller" <davem@...emloft.net>, <amwang@...hat.com>,
	<netdev@...r.kernel.org>, <horms@...ge.net.au>
Subject: RE: [Patch net-next] net: clean up skb headers code

> Of course - we need to look at the value that ALL_ONES()
> generates in an expression. So the test print needs to be:
> 	printf("%hhx %hhx %hx %hx %x %x %lx %lx %llx %llx\n",
> 		ALL_ONES(a), ALL_ONES(b), ALL_ONES(c), ALL_ONES(d),
> 		ALL_ONES(e), ALL_ONES(f), ALL_ONES(g), ALL_ONES(h),
> 		ALL_ONES(i), ALL_ONES(j));
> which then gives 0xffffffff for the first 4 entries.

Except I copied the wrong format line :-( It should be:
 	printf("%x %x %x %x %x %x %lx %lx %llx %llx\n",
 		ALL_ONES(a), ALL_ONES(b), ALL_ONES(c), ALL_ONES(d),
 		ALL_ONES(e), ALL_ONES(f), ALL_ONES(g), ALL_ONES(h),
 		ALL_ONES(i), ALL_ONES(j));

	David