netdev - Re: [PATCH net-next] gro: should aggregate frames without DF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370034733.5109.110.camel@edumazet-glaptop>
Date:	Fri, 31 May 2013 14:12:13 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Jerry Chu <hkchu@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next] gro: should aggregate frames without DF

On Fri, 2013-05-31 at 21:09 +0100, Ben Hutchings wrote:

> But this results in ignoring the actual offset bits of frag_off!
> We should allow merging only if all packets have frag_off == IP_DF or
> all have frag_off == 0.  The first assignment of flush therefore still
> needs to check the combined id/frag_off word, but using (id & ~IP_DF)
> instead of (id ^ IP_DF).

You're right, I guess I wanted too much getting rid of black magic in
this code ;)

I'll send a v2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html