netdev - Re: [Patch net-next] vxlan: do real refcnt for vn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130530205618.0d3a8d16@nehalam.linuxnetplumber.net>
Date:	Thu, 30 May 2013 20:56:18 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] vxlan: do real refcnt for vn_sock

On Fri, 31 May 2013 10:55:45 +0800
Cong Wang <amwang@...hat.com> wrote:

> On Wed, 2013-05-29 at 16:39 +0800, Cong Wang wrote:
> > On Tue, 2013-05-28 at 21:41 -0700, Stephen Hemminger wrote:
> > > Why not just fix the requirement to drop rtnl when calling igmp.
> > > The code comes out cleaner and safer as well.
> > 
> > Besides you forget to lock the socket before calling _ip_mc_join_group()
> > (and also the order is very important too), your patch doesn't fix the
> > problem I met. The full backtrace is below:
> > 
> 
> Hi, Stephen,
> 
> Do you think my patch is an easier solution? It at least fixes the
> crash, while your patch doesn't. :)
> 
> 

No. your patch doesn't fix the real problem.
The real fix is more complex because of how socket locking interacts with RTNL.

I have been busy with health stuff, so the going is slow.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html