netdev - RE: [PATCH 6/7] qlcnic: remove redundant D0 power state set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C562D0E12CBDE44E8A0CCAB7706009673539F21B@AVMB1.qlogic.org>
Date:	Fri, 31 May 2013 13:48:27 +0000
From:	Rajesh Borundia <rajesh.borundia@...gic.com>
To:	Yijing Wang <wangyijing@...wei.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	Hanjun Guo <guohanjun@...wei.com>, Jiang Liu <liuj97@...il.com>
Subject: RE: [PATCH 6/7] qlcnic: remove redundant D0 power state set

>-----Original Message-----
>From: Yijing Wang [mailto:wangyijing@...wei.com]
>Sent: Thursday, May 30, 2013 3:56 PM
>To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko
>Cc: linux-kernel; Dept-Eng Linux Driver; netdev; Hanjun Guo; Jiang Liu;
>Yijing Wang
>Subject: [PATCH 6/7] qlcnic: remove redundant D0 power state set
>
>Pci_enable_device() will set device power state to D0,
>so it's no need to do it again in qlcnic_attach_func().
>
>Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>index aeb26a8..3585c2c 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev
>*pdev)
> 	if (err)
> 		return err;
>
>-	pci_set_power_state(pdev, PCI_D0);
> 	pci_set_master(pdev);
> 	pci_restore_state(pdev);
>
>--
>1.7.1
>
>

Acked-by: Rajesh Borundia <rajesh.borundia@...gic.com>

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html