netdev - Re: [PATCH v2] snmp6: fix title of IPSTATS_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370013236.5109.100.camel@edumazet-glaptop>
Date:	Fri, 31 May 2013 08:13:56 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] snmp6: fix title of IPSTATS_MIB_CSUMERRORS

On Fri, 2013-05-31 at 15:32 +0200, Nicolas Dichtel wrote:
> Follow the same convention than other fields, prefix this stat by 'Ip6'.
> 
> Spotted-by: Fujie Zhao <fujie.zhao@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
> 
> In fact, I wonder if we cannot simply remove this stat for IPv6: there is no
> checksum in IPv6, so it will always be 0 (and in fact, this stats is only
> increased in net/ipv4/ip_input.c).

You could put this line in a comment, so that a future reader knows why
we do have a hole.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html