netdev - Re: [Patch net-next v2] net: clean up skb headers code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130531.170322.303782960714462064.davem@davemloft.net>
Date:	Fri, 31 May 2013 17:03:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, horms@...ge.net.au
Subject: Re: [Patch net-next v2] net: clean up skb headers code 

From: Cong Wang <amwang@...hat.com>
Date: Wed, 29 May 2013 15:16:05 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> commit 1a37e412a0225fcba5587 (net: Use 16bits for *_headers
> fields of struct skbuff) converts skb->*_header to u16,
> some #if NET_SKBUFF_DATA_USES_OFFSET are now useless,
> and to be safe, we could just use "X = (typeof(X)) ~0U;"
> as suggested by David.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Simon Horman <horms@...ge.net.au>
> Signed-off-by: Cong Wang <amwang@...hat.com>

After much internal deliberation, I still like this approach the
best because it prevents mistakes in the future.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html