netdev - Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370049940.10556.100.camel@joe-AO722>
Date:	Fri, 31 May 2013 18:25:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lorenzo Colitti <lorenzo@...gle.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	David Miller <davem@...emloft.net>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h

On Sat, 2013-06-01 at 10:05 +0900, Lorenzo Colitti wrote:
> Reduce the indentation of most of the functions and make it a
> bit more consistent. This allows longer function and arg names
> to be consistently indented without wrapping.
[]
> diff --git a/include/net/transp_v6.h b/include/net/transp_v6.h
[]
> @@ -7,47 +7,47 @@
[]
>  /* extension headers */
> -extern int				ipv6_exthdrs_init(void);
[]
> +extern int		ipv6_exthdrs_init(void);

externs aren't useful here and I suggest prototypes like
int ipv6_exthdrs_init(void);

> -extern int			ip6_datagram_send_ctl(struct net *net,
> -						      struct sock *sk,
> -						      struct msghdr *msg,
> -						      struct flowi6 *fl6,
> -						      struct ipv6_txoptions *opt,
> -						      int *hlimit, int *tclass,
> -						      int *dontfrag);
[]
> +extern int		ip6_datagram_send_ctl(struct net *net,
> +					      struct sock *sk,
> +					      struct msghdr *msg,
> +					      struct flowi6 *fl6,
> +					      struct ipv6_txoptions *opt,
> +					      int *hlimit, int *tclass,
> +					      int *dontfrag);

int ip6_datagram_send_ctl(struct net *net, struct sock *sk, struct msghdr *msg,
			  struct flowi6 *fl6, struct ipv6_txoptions *opt,
			  int *hlimit, int *tclass, int *dontfrag);

etc...

kernel_doc might be nice too

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html