netdev - Re: [PATCH] ssb: sprom: replace strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130601111055.1f9fcf4c@milhouse>
Date:	Sat, 1 Jun 2013 11:10:55 +0200
From:	Michael Büsch <m@...s.ch>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	netdev@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	"'David S. Miller'" <davem@...emloft.net>
Subject: Re: [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul()

On Sat, 01 Jun 2013 16:35:23 +0900
Jingoo Han <jg1.han@...sung.com> wrote:

> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.

Looks good. John, can you apply, please?

> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/ssb/sprom.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index a3b2364..e753fbe 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
>  	while (cnt < sprom_size_words) {
>  		memcpy(tmp, dump, 4);
>  		dump += 4;
> -		err = strict_strtoul(tmp, 16, &parsed);
> +		err = kstrtoul(tmp, 16, &parsed);
>  		if (err)
>  			return err;
>  		sprom[cnt++] = swab16((u16)parsed);



-- 
Michael

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)