netdev - Re: [Patch net-next] icmp: avoid allocating large struct on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1370135682.2637.1.camel@cr0>
Date:	Sun, 02 Jun 2013 09:14:42 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] icmp: avoid allocating large struct on stack

On Fri, 2013-05-31 at 22:22 -0700, Eric Dumazet wrote:
> On Sat, 2013-06-01 at 11:24 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@...hat.com>
> > 
> > struct icmp_bxm is a large struct, reduce stack usage
> > by allocating it on heap.
> > 
> 
> Strange, I posted a patch like that some days ago.

Strange, why it isn't merged. :)

> 
> Please.
> 
> Read carefully this code and tell me if you do not leak memory.

Right, I missed some kfree.

> 
> For the record my patch was saving more stack space :

Please submit it as a normal patch?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html