netdev - Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Jun 2013 12:44:58 +0900
From:	Lorenzo Colitti <lorenzo@...gle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h

On Sun, Jun 2, 2013 at 12:06 PM, Joe Perches <joe@...ches.com> wrote:
> How is that churn different than the entire patch?

I changed the indentation because patch 2 in the set introduced
another function and I didn't know how to indent it. Currently, some
declarations are not tab-indented, some are tab-indented to column 40,
and some are tab-indented to column 32. I thought that while I was at
it I might change them to be consistent. So this patch changes it so
they're all tab-indented to column 24; I thought that was more
readable.

That said, I don't have strong feelings about the indentation - my
main goal here was removing code duplication. If I reverted the
indentation patch and just aligned the new function to the function
above it, would that be better?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html