[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKD1Yr0rRBWZ8WcMSo-xoG=X8kptBdhFBk36CjLX72BZkHuSvw@mail.gmail.com>
Date: Sun, 2 Jun 2013 19:35:53 +0900
From: Lorenzo Colitti <lorenzo@...gle.com>
To: Joe Perches <joe@...ches.com>
Cc: David Miller <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h
On Sun, Jun 2, 2013 at 6:23 PM, Joe Perches <joe@...ches.com> wrote:
> Lorenzo, take any advice from me with whatever salts you
> think appropriate. Avoid the designer bath ones though.
Ok, so I can:
1. Not touch any of the other functions, and add the new function
prototype without any tabs (inconsistent with the others).
2. Not touch any of the other functions, and add the new function
prototype tab-indented the same as the function above it (preserves
the status quo).
3. Remove all the externs in the function prototypes, and all the
middle-of-line tabs in the file, and add the new function prototype in
the same way.
Any of the above is fine by me. Is there one which you guys agree on?
I don't have strong feelings about indentation, but if possible I
would like to avoid re-spinning this patchset more than twice over
formatting changes to this file.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists