netdev - Re: [PATCH] net_sched: restore "overhead xxx" handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1370268483.24311.145.camel@edumazet-glaptop>
Date:	Mon, 03 Jun 2013 07:08:03 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesper Dangaard Brouer <brouer@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Vimalkumar <j.vimal@...il.com>,
	Jiri Pirko <jpirko@...hat.com>
Subject: Re: [PATCH] net_sched: restore "overhead xxx" handling

On Mon, 2013-06-03 at 15:56 +0200, Jesper Dangaard Brouer wrote:

> Would it make sense to add the "overhead" in qdisc_pkt_len_init() or
> qdisc_calculate_pkt_len(), thus updating qdisc_skb_cb(skb)->pkt_len
> instead?  (And perhaps also address the per GSO issue).

qdisc_pkt_len_init() is generic (OK for all qdisc)

Each HTB class can have its own computations : 
One for the rate, one for the ceil.
It has to be done in HTB.

If only the overhead is needed, its kind of easy for GSO packets, as we
already have gso_segs in hand.

pktlen = qdisc_skb_cb(skb)->pkt_len + gso_segs * overhead;

That will be a net-next patch, since it's not a regression.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html