netdev - Re: [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130603.002404.131723623530817410.davem@davemloft.net>
Date:	Mon, 03 Jun 2013 00:24:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lorenzo@...gle.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org
Subject: Re: [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Mon, 3 Jun 2013 16:17:25 +0900

> On Mon, Jun 3, 2013 at 4:13 PM, Cong Wang <amwang@...hat.com> wrote:
>> Remember it is a cleanup, not a bug fix, right? :) I don't think there
>> is any way to make this 10- line of code hard to read.
> 
> I suppose, if growing the function from 2 to 9 lines without changing
> its behaviour can be called a "cleanup". :-)

I have to say this patch makes the code look worse, ifdefs are 99
times out of 100 the wrong thing to do.

Sorry I won't be applying these patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html