netdev - RE: [PATCH net] bnx2x: fix TCP offload for tunneling ipv4 over ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504C9EFCA2D0054393414C9CB605C37F20C96065@SJEXCHMB06.corp.ad.broadcom.com>
Date:	Mon, 3 Jun 2013 11:45:24 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Sergei Shtylyov" <sergei.shtylyov@...entembedded.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Ariel Elior" <ariele@...adcom.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
Subject: RE: [PATCH net] bnx2x: fix TCP offload for tunneling ipv4 over
 ipv6

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@...entembedded.com]
> Sent: Monday, June 03, 2013 2:28 PM
> To: Dmitry Kravkov
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Ariel Elior; Eilon Greenstein
> Subject: Re: [PATCH net] bnx2x: fix TCP offload for tunneling ipv4 over ipv6
> 
> Hello.
> 
> On 03-06-2013 13:28, Dmitry Kravkov wrote:
> 
> > FW was initialized with data from wrong header, this caused TSO packets
> > have wrong IP csum.
> 
> > Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> > Signed-off-by: Ariel Elior <ariele@...adcom.com>
> > Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> > ---
> >   drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 13 ++++++-------
> >   1 file changed, 6 insertions(+), 7 deletions(-)
> 
> > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> > index c80f1d2..37c1495 100644
> > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> > @@ -3198,11 +3198,11 @@ static u32 bnx2x_xmit_type(struct bnx2x *bp, struct sk_buff *skb)
> >   		rc |= XMIT_CSUM_TCP;
> >
> >   	if (skb_is_gso_v6(skb)) {
> > -		rc |= (XMIT_GSO_V6 | XMIT_CSUM_TCP | XMIT_CSUM_V6);
> > +		rc |= (XMIT_GSO_V6 | XMIT_CSUM_TCP);
> 
>    Maybe it's time to drop the useless ()?
> 
> >   		if (rc & XMIT_CSUM_ENC)
> >   			rc |= XMIT_GSO_ENC_V6;
> >   	} else if (skb_is_gso(skb)) {
> > -		rc |= (XMIT_GSO_V4 | XMIT_CSUM_V4 | XMIT_CSUM_TCP);
> > +		rc |= (XMIT_GSO_V4 | XMIT_CSUM_TCP);
> 
>     Oh, here as well...
> 
> WBR, Sergei
>
Net tree is not proper place for pure beautification - this can be done in net-next after this functional change is merged there


 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html