netdev - Re: [PATCH -next] net: sun4i-emac: fix a typo in emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130604132408.GD3283@lukather>
Date:	Tue, 4 Jun 2013 15:24:08 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	grant.likely@...aro.org, rob.herring@...xeda.com,
	davem@...emloft.net, sr@...x.de, yongjun_wei@...ndmicro.com.cn,
	netdev@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH -next] net: sun4i-emac: fix a typo in emac_probe()

Hi,

On Mon, Jun 03, 2013 at 09:36:52PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Just fixed a typo in emac_probe().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
> index b411344..26083cd 100644
> --- a/drivers/net/ethernet/allwinner/sun4i-emac.c
> +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
> @@ -821,7 +821,7 @@ static int emac_probe(struct platform_device *pdev)
>  	db->membase = of_iomap(np, 0);
>  	if (!db->membase) {
>  		dev_err(&pdev->dev, "failed to remap registers\n");
> -		return -ENOMEM;
> +		ret = -ENOMEM;
>  		goto out;
>  	}
>  
> 

Ouch, nice catch.
Thanks!

Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html