netdev - Re: [PATCH] iproute2: bridge: fix 'bridge link' setlink/getlink parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130603195719.34d21480@nehalam.linuxnetplumber.net>
Date:	Mon, 3 Jun 2013 19:57:19 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	vyasevic@...hat.com, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH] iproute2: bridge: fix 'bridge link' setlink/getlink
 parsing

On Wed, 29 May 2013 09:20:53 -0700
John Fastabend <john.fastabend@...il.com> wrote:

> Use IFLA_AF_SPEC nested attributes to lookup bridge mode and when
> doing strcmp() check for equality.
> 
> These appear to be typos from the original commit,
> 
> commit 64108901b737b95247b53dec8c1b8217ca8505b7
> Author: Vlad Yasevich <vyasevic@...hat.com>
> Date:   Fri Mar 15 10:01:28 2013 -0700
> 
>     bridge: Add support for setting bridge port attributes
> 
> Also set flags to BRIDGE_FLAGS_SELF instead of using OR operation.
> This allows setting the bridge mode when not being used with a
> master device.
> 
> To allow setting both master and self devices simultaneously we
> will need to add a {self|master} field similar to fdb commands.
> For now the command sets are mutually exclusive as noted in the
> original commit.
> 
> With this patch 'bridge link set' works now,
> 
> # ./bridge/bridge link set dev veth1 cost 3
> # ./bridge/bridge link show
> 10: veth1 state UP : <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 master bridge0 state forwarding priority 3 cost 3
> 
> CC: Vlad Yasevich <vyasevic@...hat.com>
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>

Looks good, applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html