netdev - Re: [PATCH net-next] cxgb3: Correct comparisons and calculations using skb->tail and skb-transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 04 Jun 2013 17:38:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	roy.qing.li@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] cxgb3: Correct comparisons and calculations
 using skb->tail and skb-transport_header

From: Simon Horman <horms@...ge.net.au>
Date: Tue, 4 Jun 2013 22:23:53 +0900

> On Tue, Jun 04, 2013 at 04:11:16PM +0800, roy.qing.li@...il.com wrote:
>> From: Li RongQing <roy.qing.li@...il.com>
>> 
>> This corrects an regression introduced by "net: Use 16bits for *_headers
>> fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set. In
>> that case skb->tail will be a pointer whereas skb->transport_header
>> will be an offset from head. This is corrected by using wrappers that
>> ensure that comparisons and calculations are always made using pointers.
>> 
>> Cc: Simon Horman <horms@...ge.net.au>
>> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> 
> Reviewed-by: Simon Horman <horms@...ge.net.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html