netdev - Re: [PATCH] ethernet/arc/arc_emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Jun 2013 16:35:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Alexey.Brodkin@...opsys.com
Cc:	netdev@...r.kernel.org, Vineet.Gupta1@...opsys.com,
	Mischa.Jonker@...opsys.com, grant.likely@...aro.org,
	rob.herring@...xeda.com, paul.gortmaker@...driver.com,
	sjhill@...s.com, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] ethernet/arc/arc_emac - Add new driver

From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Date: Tue, 4 Jun 2013 16:21:50 +0400

> +{
> +	struct arc_emac_priv *priv = netdev_priv(net_dev);
> +	struct phy_device *phydev = priv->phy_dev;
> +	u32 reg;
> +
> +	int status_change = 0;

Do not add empty lines amongst the top-level variable declarations
of a function.  Fix this in the entire driver, as needed.

> +			netdev_warn(net_dev,
> +				"Speed (%d) is not 10/100?\n", phydev->speed);

Functions calls on multiple lines must have the arguments
aligned properly on the second and subsequent lines, this
means:

		function(arg1, arg2,
			 arg3, arg4);

You must use the appropriate number of TAB and space characters
to achieve this proper column alignment, rather than only using
TAB characters as you have done here.

Audit and fix this in your entire driver.

> +static int arc_emac_get_settings(struct net_device *net_dev,
> +		struct ethtool_cmd *cmd)

The argument indention rules above apply to function definitions
as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html