netdev - Re: [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51B172F6.7050807@redhat.com>
Date:	Fri, 07 Jun 2013 07:43:18 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment

On 06/07/2013 03:20 AM, Eric Dumazet wrote:
> On Fri, 2013-06-07 at 02:07 +0200, Daniel Borkmann wrote:
>> We have the minimal inline helper tcp_skb_mss to access
>> skb_shinfo(skb)->gso_size, so also use it here to get mss.
>>
>> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
>> ---
>>   net/ipv4/tcp.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
>> index b5d4ad9..6a1cf95 100644
>> --- a/net/ipv4/tcp.c
>> +++ b/net/ipv4/tcp.c
>> @@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
>>   	oldlen = (u16)~skb->len;
>>   	__skb_pull(skb, thlen);
>>
>> -	mss = skb_shinfo(skb)->gso_size;
>> +	mss = tcp_skb_mss(skb);
>
> Conceptually, this is part of the GRO/GSO layer.
>
> It would be nice to move this stuff in net/ipv4/tcp_offload.c
> to makes things explicit.

Agreed, will do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html