netdev - Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B45013.5000708@mellanox.com>
Date:	Sun, 9 Jun 2013 12:51:15 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	<netdev@...r.kernel.org>, <amirv@...lanox.com>,
	<ronye@...lanox.com>
Subject: Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF
 link state

On 08/05/2013 19:02, Sergei Shtylyov wrote:
>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
>> index a08bd2b..bec44a3 100644
>> --- a/net/core/rtnetlink.c
>> +++ b/net/core/rtnetlink.c
>> @@ -1238,6 +1238,15 @@ static int do_setvfinfo(struct net_device 
>> *dev, struct nlattr *attr)
>>                                      ivs->setting);
>>               break;
>>           }
>> +        case IFLA_VF_LINK_STATE: {
>> +            struct ifla_vf_link_state *ivl;
>> +            ivl = nla_data(vf);
>
>     Why not make it initializer? And empty line is needed between the 
> declaration and other code. 

b/c we followed the conventions introduced in the preceding cases of 
do_setvfinfo which we found to be OK
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html