netdev - Re: [PATCH V1 net-next 1/3] net/core: Add VF link state control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+4_SU3cTYOkukgX4BRZcXOjv-orjoqx_6kVck-607sbA@mail.gmail.com>
Date:	Mon, 10 Jun 2013 18:02:33 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>, davem@...emloft.net,
	netdev@...r.kernel.org, amirv@...lanox.com, ronye@...lanox.com
Subject: Re: [PATCH V1 net-next 1/3] net/core: Add VF link state control

On Mon, Jun 10, 2013 at 5:39 PM, Ben Hutchings
<bhutchings@...arflare.com> wrote:
> On Sun, 2013-06-09 at 16:27 +0300, Or Gerlitz wrote:
> > From: Rony Efraim <ronye@...lanox.com>
> >
> > Add netlink directives and ndo entry to allow for controling
> > VF link, which can be in one of three states:
> >
> > Auto - VF link state reflects the PF link state (default)
> >
> > Up - VF link state is up, traffic from VF to VF works even if
> > the actual PF link is down
> >
> > Down - VF link state is down, no traffic from/to this VF, can be of
> > use while configuring the VF
> >
> > Signed-off-by: Rony Efraim <ronye@...lanox.com>
> > Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> [...]
> > --- a/net/core/rtnetlink.c
> > +++ b/net/core/rtnetlink.c
> > @@ -947,6 +947,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb,
> > struct net_device *dev,
> >                       struct ifla_vf_vlan vf_vlan;
> >                       struct ifla_vf_tx_rate vf_tx_rate;
> >                       struct ifla_vf_spoofchk vf_spoofchk;
> > +                     struct ifla_vf_link_state vf_linkstate;
> >
> >                       /*
> >                        * Not all SR-IOV capable drivers support the
>
> There's a bit missing here: you need to initialise ivi.linkstate to a
> default value.  I'm not sure whether that should be
> FLA_VF_LINK_STATE_AUTO (i.e. assume that's the default for all drivers/
> hardware) or whether there should be an explicit 'unknown' value.

good catch Ben. Per the discussion held over the RFC thread, the
default is auto and so will be the value I will set here prior to the
call into the drivers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html