netdev - Re: [PATCH net-next] doc:networking: Update comment for dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1370880670.1933.9.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 10 Jun 2013 17:11:10 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<Narendra_K@...l.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] doc:networking: Update comment for dev_id
 field in netdevice.h

On Mon, 2013-06-10 at 19:34 +0530, Narendra_K@...l.com wrote:
> This patch updates the comment for 'dev_id' field in
> 'include/linux/netdevice.h' to reflect the intended
> usage of 'dev_id'.
> 
> References: http://marc.info/?l=linux-netdev&m=136992115300526&w=2
> References: http://marc.info/?l=linux-netdev&m=137062569014612&w=2
> 
> Signed-off-by: Narendra K <narendra_k@...l.com>

Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

> ---
>  include/linux/netdevice.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8f967e3..a43712e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1142,8 +1142,10 @@ struct net_device {
>  	unsigned char		addr_assign_type; /* hw address assignment type */
>  	unsigned char		addr_len;	/* hardware address length	*/
>  	unsigned char		neigh_priv_len;
> -	unsigned short          dev_id;		/* for shared network cards */
> -
> +	unsigned short          dev_id;		/* Used to differentiate devices
> +						 * that share the same link
> +						 * layer address
> +						 */
>  	spinlock_t		addr_list_lock;
>  	struct netdev_hw_addr_list	uc;	/* Unicast mac addresses */
>  	struct netdev_hw_addr_list	mc;	/* Multicast mac addresses */
> -- 
> 1.8.0.1
> 

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html