netdev - Re: [PATCH 0/2] bonding: couple of bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 18:50:00 +0200
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	andy@...yhouse.net
Subject: Re: [PATCH 0/2] bonding: couple of bug fixes

On 11/06/13 18:42, Jay Vosburgh wrote:
> David Miller <davem@...emloft.net> wrote:
> 
>> From: nikolay@...hat.com
>> Date: Thu,  6 Jun 2013 13:55:00 +0200
>>
>>> From: Nikolay Aleksandrov <nikolay@...hat.com>
>>>
>>> Hello,
>>> Patch 01 resets the master's mac if the first enslave fails and the slave's
>>> mac was set to the master's prior.
>>> Patch 02 fixes a type bug of igmp_retrans (which is the counter of igmp_resend
>>> param and was silently not working if the value was >127) so it can go up to 255
>>> (as per documentation). It also fixes two tricky race conditions which were
>>> hidden because of the previous bug.
>>
>> There was some minor back and forth between Jay and Nikolay on this set,
>> but I'd like to see some ACKs before applying this stuff.
> 
> 	I'm fine with the code changes, although I think a description
> of the three way race that Nikolay described in his last email should be
> in the log message, perhaps along with a brief description of what
> conditions would trigger the problem.
> 
> 	With the above caveat:
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
> 
> 	-J
> 
> ---
> 	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks for the review Jay.
Dave how would you like me to handle this ? Should I resubmit a v2 with
updated commit message or just a reply with new commit message will
suffice ?

Nik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html