netdev - Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG2jQ8iic-u-kKpGp+OrcrHB2eDdpNsENw25BWxZiD6oDA1dNA@mail.gmail.com>
Date:	Tue, 11 Jun 2013 19:28:34 +0100
From:	Markos Chandras <markos.chandras@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Markos Chandras <markos.chandras@...tec.com>,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

On 11 June 2013 19:09, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 11-06-2013 18:57, Markos Chandras wrote:
>
>> The Vortex driver depends on PCI with optional support for EISA.
>
>
>> This fixes build problems when EISA is selected but not PCI.
>
>
>> drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of
>> function 'pci_iomap' [-Werror=implicit-function-declaration]
>> drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of
>> function 'pci_iounmap' [-Werror=implicit-function-declaration]
>
>
>> Cc: David S. Miller <davem@...emloft.net>
>> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
>> Cc: netdev@...r.kernel.org
>> Signed-off-by: Markos Chandras <markos.chandras@...tec.com>
>
>
>    The proper way to address this is probably add empty *static inline*
> function implementations for CONFIG_PCI=n case to the header file, same as
> was done with pci_{request|release}_regions() for this same file several
> years ago...
>
> WBR, Sergei
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Hi Sergei,

Sounds reasonable to me but I am not that familiar with this part of
the kernel so I can't comment on whether this is the best solution or
not.

--
Regards,
Markos Chandras
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html