netdev - Re: [PATCH v2 1/1] alx: add a simple AR816x/AR817x device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371060135.8601.32.camel@jlt4.sipsolutions.net>
Date:	Wed, 12 Jun 2013 20:02:15 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, mcgrof@...not-panic.com, kvalo@...rom.com,
	adrian.chadd@...il.com
Subject: Re: [PATCH v2 1/1] alx: add a simple AR816x/AR817x device driver

On Wed, 2013-06-12 at 00:23 +0200, Francois Romieu wrote:

Thanks for looking!

> - The bitops for alx->int_mask in alx_check_link and alx_poll race.
>   ALX_ISR_{TX/RX}_Q0 may end disabled if alx_check_link wins.

Ahrg, yes, I saw this before but forgot, sorry :-(

> - dev_alloc_skb is a bit legacy. You may netdev_alloc_skb (_ip_align ?).

Hmm, ok? This was new to me, I'll check it out as well as alignment.

> - no spin_lock_init ?

Ouch.

> - budget may not be honored in alx_clean_rx_irq

Hmm, I'll take another look. I thought only the TX part wasn't doing
this properly, but this was my first foray into real NAPI usage so I'm
not surprised I got it wrong :-)

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html