netdev - Re: [PATCH net-next] e1000e: restore call to pci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Jun 2013 14:45:56 -0500
From:	Dean Nelson <dnelson@...hat.com>
To:	jeffrey.t.kirsher@...el.com
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	David Miller <davem@...emloft.net>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	netdev@...r.kernel.org, Bruce Allan <bruce.w.allan@...el.com>
Subject: Re: [PATCH net-next] e1000e: restore call to pci_clear_master()

On 06/12/2013 02:41 PM, Jeff Kirsher wrote:
> On Wed, 2013-06-12 at 13:53 -0500, Dean Nelson wrote:
>> On 06/12/2013 01:38 PM, Sergei Shtylyov wrote:
>>> Hello.
>>>
>>> On 06/12/2013 09:47 PM, Dean Nelson wrote:
>>>
>>>> In attempting to resolve a minor merge conflict, commit
>>>> e5f2ef7ab4690d2e8faa
>>>> accidently dropped a call to pci_clear_master() that was intended to
>>>> remain
>>>> in place.
>>>
>>>> Commit 4e0855dff094b0d56d6b replaced a call to pci_disable_device() by
>>>> one to
>>>
>>>      Please specify the summary line in parens for both commmits you're
>>> mentioning.
>>
>> Sorry, I'm not understanding fully. Are you asking me to repost the
>> patch with the changelog modified, such that each of the commits
>> mentioned has their summary statement following, enclosed in parens?
>>
>>
>>>> pci_clear_master(). And then commit 66148babe728f3e00e13 deleted a
>>>> number of
>>>> lines starting two lines following that call.
>>>
>>>> This patch restores the call to pci_clear_master() in __e1000_shutdown().
>>>
>>>> Signed-off-by: Dean Nelson <dnelson@...hat.com>
>>>
>>> WBR, Sergei
>>>
>>>
>>
>> Also, I mistyped Jeff Kirsher's email address. It's corrected above.
>> (Sorry, Jeff.)
>
> No problem, will you be sending a v2 based on Sergei's feedback?  Just
> need to know if I add this patch to my queue or wait for v2.

Yes, I just sent it.


>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html