netdev - Re: [PATCH net-next] net_sched: htb: do not setup default rate estimators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130612.001441.1628304783101981390.davem@davemloft.net>
Date:	Wed, 12 Jun 2013 00:14:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net_sched: htb: do not setup default rate
 estimators

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 06 Jun 2013 14:53:16 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> With a thousand htb classes, est_timer() spends ~5 million cpu cycles
> and throws out cpu cache, because each htb class has a default
> rate estimator (est 4sec 16sec).
> 
> Most users do not use default rate estimators, so switch htb
> to not setup ones.
> 
> Add a module parameter (htb_rate_est) so that users relying
> on this default rate estimator can revert the behavior.
> 
> echo 1 >/sys/module/sch_htb/parameters/htb_rate_est
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Fair enough, applied, let's see if anyone complains.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html