netdev - Re: [PATCH] alx: add a simple AR816x/AR817x device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371162553.8335.28.camel@jlt4.sipsolutions.net>
Date:	Fri, 14 Jun 2013 00:29:13 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Johannes Stezenbach <js@...21.net>
Cc:	netdev@...r.kernel.org, mcgrof@...not-panic.com, kvalo@...rom.com,
	adrian.chadd@...il.com, romieu@...zoreil.com
Subject: Re: [PATCH] alx: add a simple AR816x/AR817x device driver

On Fri, 2013-06-14 at 00:24 +0200, Johannes Stezenbach wrote:

> [    0.939189] INFO: trying to register non-static key.
> [    0.939787] the code is fine but needs lockdep annotation.
> [    0.940387] turning off the locking correctness validator.
> [    0.940992] Pid: 1, comm: swapper/0 Not tainted 3.9.6 #2
> [    0.941589] Call Trace:
> [    0.942179]  [<ffffffff8108cead>] __lock_acquire.isra.24+0x710/0xa47
> [    0.942781]  [<ffffffff8108d87f>] lock_acquire+0xc0/0x142

I *think* this is probably the missing spin_lock_init I had forgotten.

> and after "ifconfig eth0 up":
> 
> [  539.482153] alx 0000:03:00.0: irq 45 for MSI/MSI-X
> [  539.482249] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [  539.483169] alx 0000:03:00.0 eth0: NIC Up: 1 Gbps Full
> [  539.483354] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> [  544.801438] ------------[ cut here ]------------
> [  544.801458] WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0x19b/0x201()
> [  544.801462] Hardware name: System Product Name
> [  544.801464] NETDEV WATCHDOG: eth0 (alx): transmit queue 0 timed out

Hmm, this is odd. I might just be forgetting to set something.

> 03:00.0 Ethernet controller: Qualcomm Atheros AR8161 Gigabit Ethernet (rev 08)

OTOH, I have a 8171, so maybe I messed up with my simplifications or it
simply doesn't work.

> Any idea what to try?

Does it still pass traffic after that? Or is it actually dead?

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html