netdev - Re: [PATCH] alx: add a simple AR816x/AR817x device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371095162.31941.1.camel@joe-AO722>
Date:	Wed, 12 Jun 2013 20:46:02 -0700
From:	Joe Perches <joe@...ches.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org,
	mcgrof@...not-panic.com, kvalo@...rom.com, adrian.chadd@...il.com
Subject: Re: [PATCH] alx: add a simple AR816x/AR817x device driver

On Thu, 2013-06-13 at 01:02 +0200, Francois Romieu wrote:
> Johannes Berg <johannes@...solutions.net> :
> > diff --git a/drivers/net/ethernet/atheros/alx/hw.c b/drivers/net/ethernet/atheros/alx/hw.c
[]
> > +static int __alx_read_phy_dbg(struct alx_hw *hw, u16 reg, u16 *pdata)
> > +{
> > +	int err;
> > +
> > +	err = __alx_write_phy_reg(hw, ALX_MII_DBG_ADDR, reg);
> > +	if (err)
> > +		return err;
> > +
> > +	return __alx_read_phy_reg(hw, ALX_MII_DBG_DATA, pdata);
> 
> 	return err ? err : __alx_read_phy_reg(hw, ALX_MII_DBG_DATA, pdata);

I think that's far poorer style.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html