netdev - Re: [PATCH] ipv6: fix ecmp lookup on forwarding path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130613.173829.683328203745717078.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 17:38:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org, zhi.ding@...nd.com
Subject: Re: [PATCH] ipv6: fix ecmp lookup on forwarding path

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu, 13 Jun 2013 16:04:55 +0200

> From: dingzhi <zhi.ding@...nd.com>
> 
> There is no reason to skip ECMP lookup when oif is specified. For example, when
> a packet is forwarded, the input interface is specified.
> 
> Signed-off-by: dingzhi <zhi.ding@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

There is no way this is valid.

The multipath code makes no attempt to choose a route that goes via
the interface that matches the one the user asked for in the flow key.

We must absolutely respect the OIF in the flow key during the route
lookup, this means no multipath until that code is changed to strictly
respect the OIF in the lookup key.

Otherwise what's the point of the OIF if you're going to pick a route
that doesn't match it?

I'm not apply this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html