netdev - Re: [PATCH v2 net-next] tg3: Prevent system hang during repeated EEH errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130617.160243.161622110613940981.davem@davemloft.net>
Date:	Mon, 17 Jun 2013 16:02:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nsujir@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH v2 net-next] tg3: Prevent system hang during repeated
 EEH errors.

From: "Nithin Nayak Sujir" <nsujir@...adcom.com>
Date: Mon, 17 Jun 2013 13:47:25 -0700

> From: Michael Chan <mchan@...adcom.com>
> 
> The current tg3 code assumes the pci_error_handlers to be always called
> in sequence.  In particular, during ->error_detected(), NAPI is disabled
> and the device is shutdown.  The device is later reset and NAPI
> re-enabled in ->slot_reset() and ->resume().
> 
> In EEH, if more than 6 errors are detected in a hour, only
> ->error_detected() will be called.  This will leave the driver in an
> inconsistent state as NAPI is disabled but netif_running state is still
> true.  When the device is later closed, we'll try to disable NAPI again
> and it will loop forever.
> 
> We fix this by closing the device if we encounter any error conditions
> during the normal sequence of the pci_error_handlers.
> 
> v2: Remove the changes in tg3_io_resume() based on Benjamin Poirier's
>     feedback.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Nithin Nayak Sujir <nsujir@...adcom.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html