netdev - Re: [PATCH v2 net-next] bonding: don't call alb_set_slave_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130617.162749.2209130543094101091.davem@davemloft.net>
Date:	Mon, 17 Jun 2013 16:27:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...hat.com
Cc:	vfalico@...hat.com, netdev@...r.kernel.org, fubar@...ibm.com,
	andy@...yhouse.net
Subject: Re: [PATCH v2 net-next] bonding: don't call
 alb_set_slave_mac_addr() while atomic

From: Nikolay Aleksandrov <nikolay@...hat.com>
Date: Mon, 17 Jun 2013 19:46:39 +0200

> On 17/06/13 19:30, Veaceslav Falico wrote:
>> alb_set_slave_mac_addr() sets the mac address in alb mode via
>> dev_set_mac_address(), which might sleep. It's called from
>> alb_handle_addr_collision_on_attach() in atomic context (under
>> read_lock(bond->lock)), thus triggering a bug.
>> 
>> Fix this by moving the lock inside alb_handle_addr_collision_on_attach().
>> 
>> v1->v2:
>> As Nikolay Aleksandrov noticed, we can drop the bond->lock completely.
>> Also, use bond_slave_has_mac(), when possible.
>> 
>> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
>> ---
>>  drivers/net/bonding/bond_alb.c | 40 +++++-----------------------------------
>>  1 file changed, 5 insertions(+), 35 deletions(-)
>> 
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html