netdev - Re: [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130617020109.GB15043@verge.net.au>
Date:	Mon, 17 Jun 2013 11:01:09 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Isaku Yamahata <yamahata@...inux.co.jp>
Cc:	netdev@...r.kernel.org, Chas Williams <chas@....nrl.navy.mil>
Subject: Re: [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into
 skb_tail_pointer(skb)

On Fri, Jun 14, 2013 at 05:58:31PM +0900, Isaku Yamahata wrote:
> The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
> converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
> in drivers/atm/ambassador.c.
> This patch converts skb->tail into skb_tail_pointer(skb).
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@...ge.net.au>
> Cc: Chas Williams <chas@....nrl.navy.mil>
> Signed-off-by: Isaku Yamahata <yamahata@...inux.co.jp>

Reviewed-by: Simon Horman <horms@...ge.net.au>

> ---
>  drivers/atm/ambassador.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 77a7480..62a7607 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1403,7 +1403,7 @@ static void amb_free_rx_skb (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
>    rx.host_address = cpu_to_be32 (virt_to_bus (skb->data));
>    
>    skb->data = skb->head;
> -  skb->tail = skb->head;
> +  skb_reset_tail_pointer(skb);
>    skb->len = 0;
>    
>    if (!rx_give (dev, &rx, pool)) {
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html