netdev - Re: [PATCH v2] net: fec: Fix build for MCF5272

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5DW_e33MbfJhNG0ouf5g5o04AF7UchD3xwJV30GLovoNg@mail.gmail.com>
Date:	Tue, 18 Jun 2013 13:23:13 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, Frank Li <Frank.Li@...escale.com>,
	Jim Baxter <jim_baxter@...tor.com>
Subject: Re: [PATCH v2] net: fec: Fix build for MCF5272

On Tue, Jun 18, 2013 at 12:38 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and
> baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G
> network) introduced functionality into the FEC driver which is not
> supported on MCF5272. The registers used to implement this functionality
> do not exist on MCF5272. Since register defines for MCF5272 are separate
> from register defines for other chips, building images for MCF5272 fails,
> complaining about several undefined symbols.
>
> Adding the missing register defines is not an option, since the registers
> do not exist on MCF5272. Disable the added functionality for MCF5272 builds.

Can you please show the build error message you got?

Also, it would be nice if FEC could be enabled by default on some m68k
defconfig, so that we could spot issues like this earlier.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html