netdev - Re: [PATCH] build some drivers only when compile-testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C01BC4.9080503@ti.com>
Date:	Tue, 18 Jun 2013 11:35:16 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Michal Marek <mmarek@...e.cz>
CC:	Jiri Slaby <jslaby@...e.cz>, Jeff Mahoney <jeffm@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<jirislaby@...il.com>, <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	<linux-usb@...r.kernel.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	<linux-geode@...ts.infradead.org>, <linux-fbdev@...r.kernel.org>,
	Richard Cochran <richardcochran@...il.com>,
	<netdev@...r.kernel.org>, Ben Hutchings <ben@...adent.org.uk>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>
Subject: Re: [PATCH] build some drivers only when compile-testing

On 18/06/13 07:51, Michal Marek wrote:

>> Sam Ravnborg (the kconfig ex-maintainer) once wrote that he doesn't want
>> to extend the kconfig language for this purpose (which I support). That
>> a config option is fine and sufficient in this case [1]. Except he
>> called the config option "SHOW_ALL_DRIVERS". Adding the current
>> maintainer to CCs ;).
> 
> I agree with Sam. 'depends on XY || COMPILE_TEST' is quite
> self-explanatory. And even if it's not, you can look up the help text
> for COMPILE_TEST. With "archdepends on" or "available on", you need to
> know what to look for to override the dependency.

I would rather have "depends on", when the code actually depends on
something (i.e. you can't compile/load the code otherwise), and "used
on"/"available on" when the code is just normally not used except on the
listed platforms (but nothing prevents from compiling and using the code
on all platforms).

But I'm fine with COMPILE_TEST or similar, I guess it's an acceptable
compromise and trivial to implement. Even if we had "used on" we'd still
need to update the Kconfig file when the code is being used on a new
platform, just like with COMPILE_TEST.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)