netdev - Re: [net-next 3/8] i40e: driver ethtool core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130619113825.45cc7f32@samsung-9>
Date:	Wed, 19 Jun 2013 11:38:25 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Jesse Brandeburg <jesse.brandeburg@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	Shannon Nelson <shannon.nelson@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [net-next 3/8] i40e: driver ethtool core

On Thu, 13 Jun 2013 20:55:17 -0700
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> +static const struct i40e_stats i40e_gstrings_net_stats[] = {
> +	I40E_NETDEV_STAT(rx_packets),
> +	I40E_NETDEV_STAT(tx_packets),
> +	I40E_NETDEV_STAT(rx_bytes),
> +	I40E_NETDEV_STAT(tx_bytes),
> +	I40E_NETDEV_STAT(rx_errors),
> +	I40E_NETDEV_STAT(tx_errors),
> +	I40E_NETDEV_STAT(rx_dropped),
> +	I40E_NETDEV_STAT(tx_dropped),
> +	I40E_NETDEV_STAT(multicast),
> +	I40E_NETDEV_STAT(collisions),
> +	I40E_NETDEV_STAT(rx_length_errors),
> +	I40E_NETDEV_STAT(rx_over_errors),
> +	I40E_NETDEV_STAT(rx_crc_errors),
> +	I40E_NETDEV_STAT(rx_frame_errors),
> +	I40E_NETDEV_STAT(rx_fifo_errors),
> +	I40E_NETDEV_STAT(tx_aborted_errors),
> +	I40E_NETDEV_STAT(tx_carrier_errors),
> +	I40E_NETDEV_STAT(tx_fifo_errors),
> +	I40E_NETDEV_STAT(tx_heartbeat_errors),
> +	I40E_NETDEV_STAT(tx_window_errors),
> +	I40E_NETDEV_STAT(rx_compressed),
> +	I40E_NETDEV_STAT(tx_compressed),
> +}

Why duplicate network device stats in ethtool stats?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html