netdev - Re: [PATCH net-next 07/11] sfc: Do not pass non-TCP packets into GRO code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1371683932.1956.138.camel@bwh-desktop.uk.level5networks.com>
Date:	Thu, 20 Jun 2013 00:18:52 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net-next 07/11] sfc: Do not pass non-TCP packets into
 GRO code

On Wed, 2013-06-19 at 15:56 -0700, Eric Dumazet wrote:
> On Wed, 2013-06-19 at 23:19 +0100, Ben Hutchings wrote:
> > GRO can handle non-TCP packets and pass them up without coalescing,
> > but it has to do some extra work to parse the packet which we can
> > bypass using the hardware parse result.  (Falcon won't mark TCP/IPv6
> > packets as TCP, but then it won't validate their checksums either, so
> > GRO can't coalesce them.)
> 
> Thats not exactly true. GRO can validate the checksums.

OK, maybe that changed at some point.  The original conversions to use
napi_gro_receive() were all conditional on hardware checksum validation.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html