netdev - Re: [PATCH 1/2] sh_eth: define/use EESR_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130619.005005.2262835197239818334.davem@davemloft.net>
Date:	Wed, 19 Jun 2013 00:50:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	magnus.damm@...il.com
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
	nobuhiro.iwamatsu.yj@...esas.com, linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: define/use EESR_RX_CHECK macro

From: Magnus Damm <magnus.damm@...il.com>
Date: Wed, 19 Jun 2013 15:47:47 +0900

> Hi Sergei,
> 
> On Wed, Jun 19, 2013 at 7:07 AM, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com> wrote:
>> sh_eth_interrupt() uses the same Rx interrupt mask twice to check the interrupt
>> status register -- #define EESR_RX_CHECK  and use it instead.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> Thanks for the patch, nice to see that this driver is moving forward.
> 
> Can you please include information about which SoC / board this code
> has been tested on? As you know, the actual hardware that this driver
> is operating on is not very well documented, so at least having
> information about the SoC together with the commit message or patch
> may help in the future.

Sergei, please make this suggested change and resubmit this series, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html