netdev - Re: [PATCH net-next 7/8] vxlan: Add tx-vlan offload support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51C2F5C2.5050502@cogentembedded.com>
Date:	Thu, 20 Jun 2013 16:29:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Pravin B Shelar <pshelar@...ira.com>
CC:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net-next 7/8] vxlan: Add tx-vlan offload support.

Hello.

On 20-06-2013 11:26, Pravin B Shelar wrote:

> Following patch allows transmit side vlan offload for vxlan
> devices.

> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ---
>   drivers/net/vxlan.c |   15 ++++++++++++++-
>   1 files changed, 14 insertions(+), 1 deletions(-)

> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index e53c947..a7feba4 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
[...]
> @@ -1049,13 +1050,23 @@ int vxlan_xmit_skb(struct net *net, struct vxlan_handler *vh,
[...]
> +	if (vlan_tx_tag_present(skb)) {
> +		if (unlikely(!__vlan_put_tag(skb,
> +					     skb->vlan_proto,
> +					     vlan_tx_tag_get(skb)))) {
> +			return -ENOMEM;
> +		}

    You haven't run this patch thru scripts/checkpatch.pl, have you? It 
should have warned you about using {} on single statement branch.

> +		skb->vlan_tci = 0;
> +	}
> +

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html