netdev - Re: [PATCH net-next 1/8] vxlan: Fix error handling while creating device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130620084748.2c79809f@nehalam.linuxnetplumber.net>
Date:	Thu, 20 Jun 2013 08:47:48 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net-next 1/8] vxlan: Fix error handling while creating
 device.

On Thu, 20 Jun 2013 00:26:25 -0700
Pravin B Shelar <pshelar@...ira.com> wrote:

> Delete vxlan-sock list entry from list before freeing the memory.
> 
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ---
>  drivers/net/vxlan.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 284c6c0..173705f 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1606,9 +1606,11 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
>  	err = register_netdevice(dev);
>  	if (err) {
>  		if (--vs->refcnt == 0) {
> +			hlist_del_rcu(&vs->hlist);
>  			rtnl_unlock();
> +
>  			sk_release_kernel(vs->sock->sk);
> -			kfree(vs);
> +			kfree_rcu(vs, rcu);
>  			rtnl_lock();
>  		}
>  		return err;

This will not be necessary with my next patch set, that code all changes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html